Implement typed async generators - #310
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
next/return/throwrequest protocol with Node-compatible eager starts, promise settlement ordering, exception rejection,finallybehavior, and reference-counted ownershipfor awaitover typed async generators and support thenode:timers/promisessetInterval(delay, value)async iteratorCloses #170.
Validation
pnpm -r build--quietpnpm node-compat:checkNEXT_DIST_DIR=.next-check pnpm checkwasm32-wasiruns for the async-generator protocol and timers/promises interval fixtures@scriptc/runtime-darwin-arm64pnpm test:sandbox: all plain and sanitized Linux Sandbox shards plus local Darwin/cross-target contracts passed; cold managed-image gate completed in 12.2 minutesDeliberate boundaries
Async
yield*, arbitrary structural async-iterator objects, andtimers/promises.setIntervalAbortSignal options remain explicitly fenced. The implemented delegation spelling is an explicitfor awaitloop. Library-mode generator exports retain their existing refusal.Coordination
This touches the scheduler/runtime, IR, and emitter files also modified by #288. The features are orthogonal, but whichever PR lands second will need a focused rebase around those shared seams.