Fix Sandbox command transport and pinned native setup - #295
Merged
Conversation
Build the Linux LLVM helper and runtime pack before running both test lanes, and align native cache contracts with the current target policy. Full managed Sandbox gate passed.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Sandbox gate can fail while transporting long shell commands and lacks the pinned native toolchain/artifacts now required by the default Linux backend. This makes the gate unreliable for validating compiler and runtime changes.
Upload shell programs larger than 768 bytes as script files while preserving argument quoting and the existing nonce/status-file completion checks. Install LLVM 22.1.8 development tools and sanitizer dependencies using the managed image's actual Ubuntu release, then explicitly build the Linux LLVM helper and runtime pack from the worktree before running tests. Update the custom image recipe to match.
Align native-output and cache tests with the current platform policy. Linux continues to relink complete executables while reusing frontend results; Darwin retains its existing persistent executable-cache contract. Archive-fallback verification uses the host linker after intentionally exercising a failing linker.
Validation:
SCRIPTC_LOCAL_TEST_WORKERS=1 pnpm test:sandboxpassed at3e1e61ein 10.0 minutes using the managed fallback image: all 16 plain/sanitized Sandbox workers and required local Darwin/native/external checks passed. Focused shell transport and native/cache tests passed. The custom Docker image recipe was covered by the gate's configuration tests; an image build was not run.