fix(runtime): wire manifest bridge policy into TypeScript apps - #415
Open
zuohuadong wants to merge 2 commits into
Open
fix(runtime): wire manifest bridge policy into TypeScript apps#415zuohuadong wants to merge 2 commits into
zuohuadong wants to merge 2 commits into
Conversation
|
@gustbul is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
TypeScript apps derive permissions and navigation origins from
app.zon, but the generated TypeScript runner leavesRunOptions.builtin_bridgeat its default disabled policy. Built-in bridge commands declared inapp.zonare therefore denied at runtime even when the manifest explicitly grants them.Fix
native_sdk.BridgePolicyat comptime.ts_core_main.zigintorunner.runWithOptions.Verification
zig build test-app-runner --summary all(3/3 tests passed)zig build test --summary all(passed)zig fmt --check src/app_runner/root.zig src/app_runner/ts_core_main.ziggit diff --checkscripts/gate.sh fast upstream/mainreached the affected suites, but its broader matrix is environment-blocked by missing@typescript/old, Android/Xcode SDKs, and an external arocc download; those failures are unrelated to this two-file change.