fix(cli): heartbeat do lockfile no Windows e uso por conta - #46
Open
graseeel wants to merge 3 commits into
Open
Conversation
This was referenced Aug 30, 2026
Os testes dependiam do relogio real e nao disparavam sob carga. Um deles passava por vacuidade: a assercao era verdadeira mesmo sem a protecao. Passam a acionar o heartbeat diretamente e a verificar o codigo de erro reescrito, falhando de fato quando a protecao e removida.
graseeel
force-pushed
the
fix/cli-consolidado-0.8.0
branch
from
August 30, 2026 20:28
5f4daa1 to
88e9853
Compare
graseeel
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolida em um unico PR os dois ajustes que estavam sendo enviados
separadamente, para reduzir ruido de revisao.
1. Heartbeat do lockfile no Windows (era o PR #44)
Protege o heartbeat contra lock ja liberado. Os testes que acompanhavam a
correcao dependiam do relogio real e um deles passava por vacuidade; foram
reescritos para acionar o heartbeat diretamente e verificar o codigo de erro
reescrito.
2. Uso e janelas por conta selecionada (era o PR #45)
Sem alteracao em relacao ao PR original.
Verificacao
Suite completa com
bun test, comparada commain:Os 139 sao os mesmos testes nas duas arvores (
comm -23ecomm -13vazios).typecheckem 1694, igual a main.Substitui os PRs #44 e #45, que serao fechados apontando para este.