fix(logstash source): fix partial window ack boundaries#25616
Draft
emilychendd wants to merge 1 commit into
Draft
fix(logstash source): fix partial window ack boundaries#25616emilychendd wants to merge 1 commit into
emilychendd wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
domain: sources
emilychendd
changed the title
emilychendd
force-pushed
the
codex/logstash-partial-window-ack
branch
from
f4dc04d to
1e78ace
Compare
bruceg
approved these changes
Jun 12, 2026
bruceg
left a comment
bruceg
left a comment
Member
There was a problem hiding this comment.
Makes sense to me. All of this special-casing to work around ReadyFrames makes me really wonder if that is the right abstraction for this source, but that's a refactor for another day.
Comment on lines
+1116
to
+1119
| push_window_size(&mut req, 4); | ||
| push_req(&mut req, 1, &[("message", "first partial window first")]); | ||
| push_req(&mut req, 2, &[("message", "first partial window second")]); | ||
| push_window_size(&mut req, 4); |
Member
There was a problem hiding this comment.
This reads like a protocol violation, but I suppose it's possible, so… 🤷🏻
Contributor
Author
There was a problem hiding this comment.
hmmm good point.... probably not the cause of the problem for the case we are looking at 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
logstashsource ACK path for a coalesced Lumberjack batch where a freshWindowSizearrives before the previous partial writer window has been acknowledged.The prior
#25531fix preserved completed writer-window boundaries, but a partial window followed by a fresh window in the sameReadyFramesbatch could still emit only the later ACK, for example[4]instead of[2, 4]. Filebeat can treat that asinvalid sequence number receivedbecause the ACK advances past the current pending send.This change carries the prior partial-window ACK boundary through the decoder and emits it only when the predecessor frame is present in the same
ReadyFramesbatch, avoiding duplicate ACKs when the previous partial tail was already ACKable in an earlier batch.Vector configuration
N/A
How did you test this PR?
Unit tests included. Triggering this is highly timing dependent.
Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References
Notes
@vectordotdev/vectorto reach out to us regarding this PR.pre-pushhook, please see this template.make fmtmake check-clippy(if there are failures it's possible some of them can be fixed withmake clippy-fix)make testgit merge origin masterandgit push.Cargo.lock), pleaserun
make build-licensesto regenerate the license inventory and commit the changes (if any). More details on the dd-rust-license-tool.