Skip to content

Add vapor/valkey and deprecate vapor/redis - #62

Open
fpseverino wants to merge 5 commits into
mainfrom
valkey
Open

fpseverino wants to merge 5 commits into
mainfrom
valkey

Conversation

@fpseverino

@fpseverino fpseverino commented Oct 29, 2026 •

Copy link
Copy Markdown
Member
  • Add vapor/valkey and deprecate vapor/redis
  • Update JWT and JWTKit as version 5 is now out of beta

]),
APIPackage("vapor/redis", group: "Database", versions: [
.single(ref: "main", modules: [Module("Redis", description: "Vapor wrapper for using Redis.")]),
PackageVersion("default", ref: "main", isDefault: true, deprecated: true, dependencies: [

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven’t been able to find anywhere, either here or in vapor/design, where we can add or enable the deprecated badge

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be in the theme. IIRC the API docs use a custom theme so we can add a flag there if the variable is set in Leaf

@0xTim

0xTim commented Nov 9, 2026

Copy link
Copy Markdown
Member

@fpseverino if you rebase it should contain the fixes for CI to make the build green

@fpseverino

Copy link
Copy Markdown
Member Author

@0xTim it's still failing but for different reasons. The Vapor 4 version of vapor/valkey builds successfully, and immediately after it the Vapor 5 version fails because of:
error: Disabled default traits by package 'vapor-valkey' (vapor-valkey) on package 'vapor' (vapor) that declares no traits. This is prohibited to allow packages to adopt traits initially without causing an API break.
Is it using a cached version of Vapor 4 instead of Vapor 5? Its package manifest correctly depends on 5.0.0-beta.4

@0xTim

0xTim commented Nov 10, 2026

Copy link
Copy Markdown
Member

@fpseverino yeah this does look like a caching issue. We should probably try and build different versions with different build environments/directories. I think that may require a kiln issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants