Repository navigation
fix: Proofread Part Hotel (3D integrals of scalar functions) - #87
Merged
Merged
Conversation
Fixes several small typos and calculation errors found while proofreading Part Hotel: - triple.typ: comma splice fixed to period before "In general, ..." - sph.typ: algebraic proof used theta +/- phi instead of theta +/- pi for the second illegal-angle case, inconsistent with the explanation just below it - sph.typ: "the surface ... are" -> "is" (subject-verb agreement) - sph.typ: offset-sphere conclusion referred to T as R and called spherical coordinates "polar coordinates" - psurf.typ: figure caption dropped a factor of sin(phi) in the y-component of the spherical parametrization - surfcross.typ: middle vector component for d(r)/dx was duplicated as partial z / partial x instead of partial y / partial x Closes #64
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #64.
Proofread the five files of Part Hotel (
src/triple.typ,src/sph.typ,src/psurf.typ,src/scalint.typ,src/surfcross.typ). Found and fixed the following small issues:src/triple.typ: comma splice fixed to a period before "In general, given a masssrc/sph.typ: in the algebraic proof of the "illegal angle less than zero" case, the equations usedsrc/sph.typ: "the surface of the sphere are those points" → "is those points" (subject-verb agreement).src/sph.typ: the conclusion of the offset-sphere example called the regionsrc/psurf.typ: the figure caption for the spherical-Earth parametrization dropped a factor ofsrc/surfcross.typ: in deriving the magic cross-product formula for graphs, the middle component ofNo large mathematical errors were found;
src/scalint.typchecked out with no issues.🤖 Generated with Claude Code
Generated by Claude Code