Repository navigation
README is a file, not a directory - #390
Merged
Merged
Conversation
kaladron
approved these changes
Oct 6, 2026
kaladron
left a comment
kaladron
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for catching this!
Collaborator
|
And this test failure nicely demonstrates why we need a mirror. I'll get to that shortly. |
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Fixes the GNU tar extraction guard in the build script by correctly treating README as a file rather than a directory.
Changes:
- Update the extraction precondition to check for a
READMEfile (-f) instead of a directory (-d).
| File | Description |
|---|---|
| util/build-gnu.sh | Corrects the extraction condition to detect an extracted GNU tar tree via a file check. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| # Extract GNU tar source if needed | ||
| if test ! -d "${path_GNU}/README"; then | ||
| if test ! -f "${path_GNU}/README"; then |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.