Skip to content

build-gnu.sh: fetch tarball instead of git clone - #388

Merged
kaladron merged 1 commit into
uutils:mainfrom
oech3:gnu
Oct 5, 2026
Merged

kaladron merged 1 commit into
uutils:mainfrom
oech3:gnu

Conversation

@oech3

@oech3 oech3 commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@oech3
oech3 force-pushed the gnu branch 2 times, most recently from 72f7e22 to d18ed2a Compare October 5, 2026 06:56
@oech3
oech3 marked this pull request as ready for review October 5, 2026 06:56
@oech3
oech3 requested a review from kaladron as a code owner October 5, 2026 06:56
@codspeed

codspeed Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 7 untouched benchmarks


Comparing oech3:gnu (d18ed2a) with main (37ce07b)

Open in CodSpeed

Comment thread util/build-gnu.sh

# Bootstrap requires gnulib and generates the configure script
./bootstrap --skip-po
curl -L https://ftpmirror.gnu.org/tar/tar-1.35.tar.xz | tar xJf - --strip-components=1

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we can upload a copy of the tarball do GitHub in our artifacts. It seems like we should cache this. Do you know if that's possible?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is possible. But I think we should have our own mirrors of all GPL projects and do that at there, not at this repo.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://ftpmirror.gnu.org redirects to other mirror e.g. https://ftp.jaist.ac.jp/pub/GNU// . So I think load is not a problem.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reliability I'd like to see us do that in another step. IT's also just good practice for supply chain security given the large number of mirrors, etc. (Not for this PR for sure, though)

This comment was marked as resolved.

@kaladron
kaladron merged commit f7858a0 into uutils:main Oct 5, 2026
17 checks passed
@oech3
oech3 deleted the gnu branch October 5, 2026 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants