grep: separate context groups across files - #131
Open
SichenLiang wants to merge 1 commit into
Open
SichenLiang wants to merge 1 commit into
SichenLiang wants to merge 1 commit into
Conversation
Track whether a previous file printed a context group so the first group in a later file receives a separator. Within a file, continue to separate only groups with a gap between their printed lines. Cover the default, disabled and custom separators, including recursive searches across two directories.
Merging this PR will not alter performance
Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Track whether an earlier file printed a context group so that the first group in a later file receives a separator. The existing line-gap check still decides when two groups within the same file need one.
Tests cover the default separator,
--no-group-separator, a custom separator, and recursive searches over two directories.One case remains: if a binary file matches before a text file, GNU starts the text output with a separator, while this change does not. For example:
GNU stdout begins with
--\ntext:hit\n; this change printstext:hit\n. Both report the binary match on stderr and exit 0.Fixes #130