Conversation
The -ls formatter only knew directories and regular files and ignored setuid, setgid and sticky bits. Use uucore::fs::display_permissions, as -printf %M already does.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #892 +/- ##
==========================================
+ Coverage 92.27% 92.34% +0.06%
==========================================
Files 35 35
Lines 7576 7527 -49
Branches 393 384 -9
==========================================
- Hits 6991 6951 -40
+ Misses 443 438 -5
+ Partials 142 138 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Commit bc99f80 has test result changes: bfs testsuite: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #890.
-lsused its own permission formatter, which only knew directories and regular files and ignored setuid, setgid and sticky bits: symlinks showed?rwxrwxrwx,/dev/null?rw-rw-rw-and/tmpdrwxrwxrwx. This usesuucore::fs::display_permissions, which-printf %Malready uses, and adds an integration test with a 4755 file and a symlink.Against GNU find 4.9.0 the permission column now matches for every entry in a tree with special modes, a symlink, a broken symlink, a fifo and a socket, and for
/dev/null. The missing-> targetfor symlinks, the date and the block count are unchanged here.cargo fmt --check,cargo clippy --all-targets -- -D warningsandcargo testpass.Written with AI assistance (Claude); I have reviewed the change.