Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #874 +/- ##
==========================================
+ Coverage 92.22% 92.40% +0.18%
==========================================
Files 35 36 +1
Lines 7524 7691 +167
Branches 390 397 +7
==========================================
+ Hits 6939 7107 +168
+ Misses 443 442 -1
Partials 142 142 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Commit 603c919 has test result changes: bfs testsuite: |
sylvestre
force-pushed
the
find-diagnostics
branch
from
September 27, 2026 09:23
603c919 to
d68c009
Compare
|
Commit d68c009 has test result changes: bfs testsuite: |
sylvestre
force-pushed
the
find-diagnostics
branch
from
September 27, 2026 10:15
d68c009 to
60025bb
Compare
Quote the predicate or operator as GNU 4.10.0 does, report an operator cut off by ')' and an unmatched ')' with GNU's messages, and name a binary operator as spelled.
Lets an unclosed '(' be pointed at later. No behaviour change.
Add a `ParseError` carrying the argument index and a label. Its Display is the bare message, so output is unchanged.
sylvestre
force-pushed
the
find-diagnostics
branch
from
September 27, 2026 15:37
60025bb to
4112abc
Compare
|
Commit 4112abc has test result changes: bfs testsuite: |
The suggestion travels as help text, so the message stays GNU's. The parser now matches on a `Predicate` looked up in a single name table, which also supplies the suggestions: a table entry the parser does not handle fails the exhaustive match, and a variant missing from the table is flagged as never constructed.
Underline the offending argument through `uucore::diagnostics` when stderr is a terminal or `UUTILS_DIAG=always`. The plain line still leads, and captured output stays the single GNU line. The report heading comes from uucore's `util_name()`, which keeps the `.exe` on Windows; the plain line keeps `program_name()` like every other message.
sylvestre
force-pushed
the
find-diagnostics
branch
from
September 27, 2026 17:28
4112abc to
4c15fdb
Compare
|
Commit 4c15fdb has test result changes: bfs testsuite: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a
findexpression is long, a single error line doesn't say where the problem is. This series makes expression parse errors record the argument they refer to. When stderr is a terminal, or whenUUTILS_DIAG=alwaysis set,findthen underlines that argument on the echoed command line and adds a "did you mean" suggestion for a mistyped predicate:When stderr is piped or redirected (scripts, the GNU and bfs testsuites), output is still the single line, byte-for-byte what GNU prints.
UUTILS_DIAG=neverforces that everywhere.