deps: migrate from chrono to jiff by wtcpython · Pull Request #871 · uutils/findutils

wtcpython · 2026-09-26T00:57:28Z

Replace chrono with jiff across find and locate.

codecov · 2026-09-26T00:58:44Z

Codecov Report

❌ Patch coverage is 87.62887% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.24%. Comparing base (8f17c13) to head (ff99276).

Files with missing lines	Patch %	Lines
src/locate/mod.rs	63.33%	8 Missing and 3 partials ⚠️
src/find/matchers/printf.rs	95.83%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #871      +/-   ##
==========================================
- Coverage   92.27%   92.24%   -0.04%     
==========================================
  Files          35       35              
  Lines        7576     7595      +19     
  Branches      393      397       +4     
==========================================
+ Hits         6991     7006      +15     
- Misses        443      445       +2     
- Partials      142      144       +2

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codspeed · 2026-09-26T01:01:39Z

Merging this PR will not alter performance

✅ 20 untouched benchmarks

_{Comparing wtcpython:jiff-migration (ff99276) with main (8f17c13)}

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

sylvestre · 2026-09-26T10:52:50Z

-                writeln!(out, "Database was last modified at {}", time)?;
+                if let Ok(ts) = jiff::Timestamp::try_from(time) {
+                    let time = ts.to_zoned(jiff::tz::TimeZone::system());
+                    writeln!(out, "Database was last modified at {}", time)?;


this changes the output: chrono printed 2025-01-15 09:30:21.123 +01:00, jiff's Display prints 2025-01-15T09:30:21.123+01:00[Europe/Paris].
is that intended? if not, please use an explicit strftime.

sylvestre · 2026-09-26T10:52:58Z

+            format!("{} {}", now.strftime("%b"), now.strftime("%d")),
+            |m| m.as_str().to_string(),
+        );
+        let mut month_chars = month_day.chars();


why is this needed? jiff's %b parsing is already case-insensitive, so this could be removed, no?

sylvestre · 2026-09-26T10:54:58Z

-                    .to_string()
+                zoned.strftime(CTIME_FORMAT).to_string()
            }
+            Self::Strftime(format) => zoned.strftime(format).to_string(),


strftime(..).to_string() panics if formatting fails.
apply already returns a Result, could you please use jiff::fmt::strtime::format and ? here?

sylvestre · 2026-09-26T10:55:03Z

-                        Err(format!("Invalid time specifier: %{first}{c}").into())
-                    }
-                    Some(_item) => Ok(TimeFormat::Strftime(format)),
+                let dummy = jiff::Zoned::now();


do we need Zoned::now() for every specifier? a fixed timestamp would do.

sylvestre · 2026-09-26T10:55:10Z

+            .start_of_day()
+            .unwrap();
+        let ts = midnight.timestamp();
+        UNIX_EPOCH + Duration::from_secs(ts.as_second() as u64)


SystemTime::from(midnight.timestamp()) would avoid the as u64 cast, no?

sylvestre · 2026-09-26T10:55:21Z


    #[test]
    #[cfg(target_pointer_width = "64")]
    fn db_too_old_ignores_max_age_beyond_chrono_range() {


the name still says chrono, please rename it (or drop it if it no longer tests anything specific)

sylvestre · 2026-09-26T10:55:29Z

+    if let Ok(datetime) = jiff::civil::DateTime::strptime("%Y-%m-%d %H:%M:%S", date_str) {
+        return Some(
+            datetime
+                .to_zoned(jiff::tz::TimeZone::UTC)


.to_zoned(TimeZone::UTC).ok()?.timestamp().as_millisecond() appears 3 times, could be dedup, no?
TimeZone::UTC.to_timestamp(dt) is shorter too.

sylvestre · 2026-09-26T10:55:34Z


 impl TimeFormat {
    fn apply(&self, time: SystemTime) -> Result<Cow<'static, str>, Box<dyn Error>> {
+        let zoned = jiff::Timestamp::try_from(time)?.to_zoned(jiff::tz::TimeZone::system());


this is now computed for SinceEpoch too, where it isn't used, and it can make %A@ fail for times outside jiff's range.
could you please move it into the branches that need it?

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

sylvestre · 2026-09-26T14:53:06Z

    #[cfg(target_pointer_width = "64")]
-    fn db_too_old_ignores_max_age_beyond_chrono_range() {
-        assert!(!is_db_too_old(TimeDelta::days(1), 1_000_000_000_000));
+    fn db_too_old_ignores_max_age_beyond_range() {


with checked_mul, 1e12 days no longer overflows, so this test is now the same as db_too_old_compares_ordinary_ages.
could you please drop it, or use a value that really overflows?

sylvestre · 2026-09-26T14:53:12Z

            let system_time = metadata.modified().unwrap();
-            let now_utc: DateTime<chrono::Utc> = system_time.into();
-            now_utc.format("%b %e %H:%M")
+            let ts = jiff::Timestamp::try_from(system_time).unwrap();


could we avoid the unwrap() here? a file with an mtime outside jiff's range would make -ls panic

sylvestre · 2026-09-26T14:53:18Z

        let year = match captures.get(2) {
            Some(m) => m.as_str().parse().ok()?,
-            None => now.year(),
+            None => now.year() as i32,


i32::from(now.year()) instead of as, no?

sylvestre · 2026-09-26T14:53:25Z

-        let now_but_zero_hour_min_sec = Utc::now()
-            .date_naive()
-            .and_hms_opt(0, 0, 0)
+        let now_but_zero_hour_min_sec = jiff::Timestamp::now()


TimeZone::UTC.to_timestamp(..) would be shorter here too, like in the function

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

github-actions · 2026-10-02T12:43:43Z

Commit ff99276 has test result changes:

bfs testsuite:

Test results comparison:
  Current:   TOTAL: 315 / PASSED: 272 / FAILED: 37 / SKIPPED: 6
  Reference: TOTAL: 316 / PASSED: 273 / FAILED: 37 / SKIPPED: 6

Changes from main branch:
  TOTAL: -1
  PASSED: -1
  FAILED: +0

No result in this run (2) - hung, crashed, or renamed:
  ? gnu/executable (was PASS)
  ? posix/exec_plus_semicolon (was PASS)

wtcpython marked this pull request as ready for review September 26, 2026 01:06

Copilot AI lite review requested due to automatic review settings September 26, 2026 01:06

Copilot AI reviewed Sep 26, 2026

sylvestre reviewed Sep 26, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings September 26, 2026 11:22

wtcpython force-pushed the jiff-migration branch from b015f8a to 277c26b Compare September 26, 2026 11:22

Copilot AI reviewed Sep 26, 2026

sylvestre reviewed Sep 26, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings September 27, 2026 00:28

wtcpython force-pushed the jiff-migration branch from 277c26b to 0892f09 Compare September 27, 2026 00:28

Copilot AI reviewed Sep 27, 2026

Copilot AI review requested due to automatic review settings September 28, 2026 00:39

wtcpython force-pushed the jiff-migration branch from 0892f09 to 4c0e5e6 Compare September 28, 2026 00:39

Copilot AI reviewed Sep 28, 2026

Copilot AI review requested due to automatic review settings September 29, 2026 06:21

wtcpython force-pushed the jiff-migration branch from 4c0e5e6 to 6574658 Compare September 29, 2026 06:21

Copilot AI reviewed Sep 29, 2026

deps: migrate from chrono to jiff

ff99276

Copilot AI lite review requested due to automatic review settings October 2, 2026 12:12

wtcpython force-pushed the jiff-migration branch from 6574658 to ff99276 Compare October 2, 2026 12:12

Copilot AI reviewed Oct 2, 2026

Conversation

wtcpython commented Sep 26, 2026

Uh oh!

codecov Bot commented Sep 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

codspeed Bot commented Sep 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Oct 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov Bot commented Sep 26, 2026 •

edited

Loading

codspeed Bot commented Sep 26, 2026 •

edited

Loading