Repository navigation
basenc: decode --base58 input in one piece - #15852
Open
vibhuthespeedst wants to merge 1 commit into
Open
vibhuthespeedst wants to merge 1 commit into
vibhuthespeedst wants to merge 1 commit into
Conversation
Base58 text is one big number, but the decoder flushed every 1024 digits, so longer input decoded to the wrong bytes and basenc could not read back its own output. Fixes uutils#15776
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15776
Base58 text is one big number, but
fast_decode_bufferdecoded and flushed the buffer every 1024 digits, so longer input decoded to the wrong bytes andbasenc --base58couldn't read back its own output.Removed that early flush. Only base58 uses this path, and it is now decoded in one go after the loop, like the encoder already does.
Added a round-trip test with input well over 1024 digits.