Repository navigation
uucore: version_cmp: compare endings when stems tie as versions - #15851
Open
vibhuthespeedst wants to merge 1 commit into
Open
vibhuthespeedst wants to merge 1 commit into
vibhuthespeedst wants to merge 1 commit into
Conversation
Endings were only compared when the stems were byte-identical, so tool-1.00.txt and tool-1.0.exe compared Equal and sort -V -u dropped one of them. Fixes uutils#15795
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15795
version_cmponly put the file endings back when the stems were byte-identical. Stems liketool-1.00andtool-1.0tie as versions but not as bytes, so the endings were never compared andsort -V -udropped one of the lines.The endings are now also kept when the stems compare equal as versions, which matches the rule in the GNU manual.
Added a unit test with the pairs from the issue, plus a
sort -V -utest.