Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In column mode
folddropped zero-width characters (U+200B, joiners, combining marks, a BOM) that came directly after a newline. The loop that attaches zero-width characters to the preceding character ran before the'\n'check, so it consumed them, and the newline branch then emitted the line and continued without pushing those bytes.The newline check now runs before that loop, so the zero-width characters are handled with the next line as usual.
Before,
342 200 213was missing.-band-cwere not affected.test_zero_width_after_newline_in_column_modefails on main.Closes #15750