Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
TMPDIRset to the empty string,mktemp -t T,mktemp -d -t T,mktemp --tmpdir Tandmktemp -p DIR -t Tcreated the file in the current directory and printed a bare name. GNU treats an emptyTMPDIRas unset.The template arm of
Options::fromnow ignores an emptyTMPDIRfor-t, and its fallback goes throughget_tmpdir_env_or_default(), the helper the no-template path already uses. That also lets-p DIRapply whenTMPDIRis empty, and removes the duplicated WASI branch.Before, these printed
foorx8andfooUlY, created in the current directory.test_empty_tmpdir_env_var_with_templatecovers all four forms and fails on main.Closes #15790