Repository navigation
Conversation
pty_path is not available on redox, so gate the PTY-based more and stty tests accordingly, and only import at_and_ucmd in the nohup test that uses it.
Collaborator
|
Is there a better solution than just disabling the tests? |
Contributor
|
https://docs.rs/rustix/latest/rustix/pty/index.html But currently, I don't see any problem with disabling them. |
Contributor
|
We could run some tests using |
Collaborator
|
I will address this by closing #15834. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pty_pathis not available on redox, socargo check --all-targets --features more,stty,nohup --target x86_64-unknown-redoxfails to compile the tests.test_more.rs,test_stty.rs: every test needs a PTY, so exclude the whole file on redoxtest_nohup.rs:at_and_ucmdwas imported for all unix targets but is only used by a test that is not built on redox, which produced an unused import warning. It is now imported inside that test.I checked that the command above fails before this change and passes without errors or warnings after it.
Closes #15827