Repository navigation
expr: anchor every top-level alternative of a regex - #15829
Open
anubhavgupta121 wants to merge 1 commit into
Open
anubhavgupta121 wants to merge 1 commit into
anubhavgupta121 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15782
Problem: The implicit start anchor as a bare '^' was added without any other modifications to the regex logic, so with '| ' (or |, which has lower priority than ^, the ^ only applies to the first alternative, and the others can match anywhere in the string.
Fix: The fix basically wraps the regex with brackets (non-capturing groups, so the anchor '^' applies to every alternative) and then '^' is added so "^(?: ...)" in build_regex(). It's non-capturing, so any further referencing, such as capture group numbering or back-references like
\1, isn't affected.Tests: added cases where a later alternative matches only after offset 0, which the existing tests didn’t cover.