Repository navigation
sort: don't rewrite a -t<chars> file operand after -- - #15823
Open
sarankumar1325 wants to merge 1 commit into
Open
sarankumar1325 wants to merge 1 commit into
sarankumar1325 wants to merge 1 commit into
Conversation
The `-t<chars>` to `--field-separator=<chars>` rewrite ran on every argument, including file operands after `--`, so `sort -- -t=` tried to use `=` as a separator instead of reading the file `-t=`. Stop the rewrite once `--` has been seen, as in cut (uutils#15806).
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #15806, which mentions that
sorthas the same problem ascut.uumainrewrites every attached-t<chars>argument to--field-separator=<chars>before clap parsing, so-t=keeps=as the separator. The rewrite also ran on file operands after--, sosort -- -t=treated-t=as a separator option instead of reading the file-t=.The rewrite now stops once
--has been seen, the same as thecutfix in #15822.Tests
test_separator_like_file_operand_after_double_dash:sort -- -t=reads and sorts the file-t=. It fails onmainand passes with this change.cargo test --features "cut sort" --no-default-features --test tests: 317 passed.cargo fmt --checkandcargo clippy -p uu_sort -- -D warningsare clean.I used an AI assistant while working on this; I reviewed the change and the tests myself.