[xtqqczze]

utmpx not supported for opensbd

[oech3]

I might hardcoded feat_os_unix at previous PR.

[xtqqczze]

Yes, you removed feat_os_unix in #15547. I don't think that is right though as we now don't check feat_Tier1.

[xtqqczze]

@oech3 matrix build is unnecessary though, how about:

    env:
      FEATURES: "feat_Tier1,feat_require_unix"

[oech3]

It FEATURES something officially supported by cargo? If not, I'd avoid environment variables to avoid sideffects.

[xtqqczze]

It FEATURES something officially supported by cargo?

No it is not. However, using a build matrix makes the job name more complex, for example:

Style and Lint (feat_Tier1,feat_require_unix)

instead of

Style and Lint

[oech3]

Keep this thread and wait maintainer's review.

[codspeed]

Merging this PR will not alter performance

1 warning, 1 note

⚠️ 123 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

ℹ️ 1 benchmark has no flamegraph

The flamegraph wasn't generated: most of the time was spent in runtime internals, which would leave nothing useful to analyze.

See affected benchmarks

✅ 401 untouched benchmarks
⏩ 70 skipped benchmarks¹

---

_{Comparing xtqqczze:build/openbsd-utmpx (e19098c) with main (1d6ca65)²}

Footnotes

1. 70 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

2. No successful run was found on main (0776385) during the generation of this report, so 1d6ca65 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩