Skip to content

Don't build std*_was_closed for fuchsia - #15732

Open
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:ebadf-open
Open

oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:ebadf-open

Conversation

@oech3

@oech3 oech3 commented Oct 25, 2026

Copy link
Copy Markdown
Contributor

This causes build failure at some utils.

@oech3 oech3 changed the title Don't build exclude std*_was_closed for fuchsia Don't build std*_was_closed for fuchsia Oct 25, 2026
@xtqqczze

xtqqczze commented Oct 25, 2026 •

Copy link
Copy Markdown
Collaborator

Please revert the changes to src/uucore/src/lib/features/signals.rs. We don't build the signals feature for Fuchsia targets as the platform does not support Unix signals.

@xtqqczze

Copy link
Copy Markdown
Collaborator

Follow-up to #14166.

@xtqqczze

xtqqczze commented Oct 25, 2026 •

Copy link
Copy Markdown
Collaborator

cat now builds successfully on Fuchsia targets with these changes:

RUSTC_BOOTSTRAP=1 cargo clippy -q -Zbuild-std=std \
  -p uu_cat --lib --target x86_64-unknown-fuchsia

We just need to fix tests now:

$ RUSTC_BOOTSTRAP=1 cargo clippy -q -Zbuild-std=std --features cat --target x86_64-unknown-fuchsia   
error[E0425]: cannot find function `setrlimit` in module `C`
   --> ~/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/rlimit-0.11.0/src/unix.rs:37:27
    |
 37 |     let ret = unsafe { C::setrlimit(resource.as_raw() as _, &rlim) };
    |                           ^^^^^^^^^ not found in `C`
    |
...

See #15831.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants