Repository navigation
Conversation
sylvestre
reviewed
Oct 25, 2026
| let (at, mut ucmd) = at_and_ucmd!(); | ||
| ucmd.args(&["-", "/2/", "2", pattern]) | ||
| .pipe_in("1\n2\n3\n") | ||
| .timeout(std::time::Duration::from_secs(10)) |
Contributor
There was a problem hiding this comment.
do we need this? the default timeout already catches a hang
limadog9
force-pushed
the
fix/csplit-negative-offset-hang-15653
branch
from
October 25, 2026 11:44
2d02f15 to
96dacb6
Compare
limadog9
force-pushed
the
fix/csplit-negative-offset-hang-15653
branch
from
October 25, 2026 13:33
96dacb6 to
ac66477
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clear rewind mode before regex searches to prevent hangs after empty numeric splits. Adds four regression cases; all 155 tests pass.
Closes #15653.