Repository navigation
tee: freeze pipe size - #15711
Merged
Merged
tee: freeze pipe size#15711
Conversation
sylvestre
reviewed
Oct 24, 2026
| let _ = fcntl_setpipe_size(&self.writers[0], MAX_ROOTLESS_PIPE_SIZE); // stdout | ||
| } | ||
| use uucore::pipes::MAX_ROOTLESS_PIPE_SIZE; | ||
| // improve throughput when stdout is pipe, but no needed to be same size with broker. |
Contributor
There was a problem hiding this comment.
"no needed" -> "no need", and the improve throughput part is enough
Contributor
Author
There was a problem hiding this comment.
This PR was merged. But I'm planning to improve comments for all utils using splice.
Contributor
|
Thanks for your PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15709 .
It is difficult to add test since it need to change system config.
(Other utils using unbuffered splice I/O do not need similar change.)