Repository navigation
uucore: keep numeric-looking arguments verbatim in clap errors - #15706
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
|
|
||
| use crate::error::{UResult, USimpleError}; | ||
| use crate::locale::translate; | ||
| use crate::translate_text; |
There was a problem hiding this comment.
could be use crate::locale::{translate, translate_text};, no?
There was a problem hiding this comment.
yep, done, thanks
368f654 to
ed2a871
Compare
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
Co-authored-by: Sylvestre Ledru <sylvestre@debian.org>
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
|
Thanks for your PR |
Part of #15533, the clap row of the table.
The shared clap error handler passed the offending argument/value through
translate!, so Fluent turned it into a number.uname 007saidunexpected argument '7' foundandls --format=007saidinvalid value '7'. Switched those three call sites totranslate_text!like the other fixes for this issue.Added tests in test_uname and test_ls, both fail on main and pass with the change. dd is the only other leftover from the table, not touched here.