[oech3]

No description provided.

[xtqqczze]

We can compile uutests once #14739 is merged.

[oech3]

I'm currently not interested in non-executbles. (--all-features might useful for devs, but it is not something for consumers.)

[xtqqczze]

We can compile uutests once #14739 is merged.

It will enable successfully compiling test targets:

 cargo check --all-targets --features feat_os_unix_redox --target x86_64-unknown-redox

[xtqqczze]

We can check with clippy once #14627 is merged.

[oech3]

clippy for minor targets are really overkill. It does not change production itself.
Disadvantage by blocking CI for it is larger than advantages.

[xtqqczze]

Disadvantage by blocking CI for it is larger than advantages.

The main blocker for CI is macOS due to reduced concurrency limits for macOS runners, see #15105.

[xtqqczze]

This is why we need CI for tests:

error[E0432]: unresolved import `uutests::util::pty_path`
    --> tests/by-util/test_more.rs:17:5
     |
  17 | use uutests::util::pty_path;
     |     ^^^^^^^^^^^^^^^--------
     |                    |
     |                    no `pty_path` in `util`
     |
note: found an item that was configured out
    --> tests/uutests/src/lib/util.rs:3115:8
     |
3114 | #[cfg(all(unix, not(target_os = "redox")))]
     |                    --------------------- the item is gated here
3115 | pub fn pty_path() -> (String, File, File) {
     |        ^^^^^^^^

error[E0432]: unresolved import `uutests::util::pty_path`
    --> tests/by-util/test_stty.rs:10:38
     |
  10 | use uutests::util::{expected_result, pty_path};
     |                                      ^^^^^^^^ no `pty_path` in `util`
     |
note: found an item that was configured out
    --> tests/uutests/src/lib/util.rs:3115:8
     |
3114 | #[cfg(all(unix, not(target_os = "redox")))]
     |                    --------------------- the item is gated here
3115 | pub fn pty_path() -> (String, File, File) {
     |        ^^^^^^^^

warning: unused import: `at_and_ucmd`
  --> tests/by-util/test_nohup.rs:12:15
   |
12 | use uutests::{at_and_ucmd, util::TestScenario, util_name};
   |               ^^^^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default

[xtqqczze]

@oech3 Please remove more, stty and nohup from feat_os_unix_redox since their tests do not compile.

[oech3]

No. Target of this PR is executables. NOT tests. You should fix tests at different PR if needed.

[xtqqczze]

Ok, we can address tests separately: #15827.