Repository navigation
pr: keep the column separator with -J - #15671
Merged
sylvestre merged 1 commit intoOct 24, 2026
Merged
Conversation
-J only turns off truncation and column alignment, as in GNU pr. The separator between columns and merged files was dropped too, so pr -2 -J -S, printed 116 instead of 1,16. The joined.log fixture recorded the glued lines; it now has the tab GNU pr writes between the merged files.
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
|
Binary size comparison: |
Contributor
|
Thanks for your PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
-J, pr drops the separator between columns and between merged files, so the columns run together:-Jonly turns off truncation and column alignment.get_line_for_printingskipped the separator wheneverjoin_lineswas set; it now writes it like in the other modes, and the unusedjoin_linesfield is gone.joined.log.expected(-J -mon two files) had the merged lines glued together (# Host DatabaseMon Dec 10 ...); GNU writes a tab between them. The fixture now has that tab and is otherwise unchanged. New testtest_join_lines_keeps_column_separatorchecks-2 -Jwith and without-S,. Both tests fail on main; the pr tests pass (85), clippy is clean. Also seen on 0.10.0.