Repository navigation
build(stty): compile on Haiku targets - #15563
Merged
Merged
Conversation
``sh RUSTC_BOOTSTRAP=1 cargo clippy -q -Zbuild-std=std -p uu_stty --lib --target x86_64-unknown-haiku ```
xtqqczze
force-pushed
the
build/stty-haiku
branch
from
October 21, 2026 12:21
cfbdb10 to
8396336
Compare
Collaborator
Author
Collaborator
Author
xtqqczze
marked this pull request as ready for review
October 21, 2026 15:28
Collaborator
Author
Contributor
|
I don't hope it since haiku is not a major target. But it is maintainer's decision. |
oech3
reviewed
Oct 21, 2026
| .iter() | ||
| .copied() | ||
| .find_map(|(i, v)| (i == cc_index).then_some(v)) | ||
| .unwrap_or(u8::from(cc_index == S::VMIN)) |
Contributor
There was a problem hiding this comment.
How about splitting this which does not conflict?
Collaborator
Author
There was a problem hiding this comment.
get_sane_control_char doesn't seem to conflict when rebased onto your PR; there's only a minor conflict elsewhere. I just wanted to keep you informed of the conflict.
That said, I think do think it would be preferable to merge this before the more substantial changes in #15299.
Contributor
|
Is this actually conflicting? |
oech3
reviewed
Oct 21, 2026
Comment on lines
275
to
281
| #[cfg(not(any( | ||
| target_os = "cygwin", | ||
| target_os = "fuchsia", | ||
| target_os = "haiku", | ||
| target_os = "hurd", | ||
| target_os = "redox" | ||
| )))] |
Contributor
There was a problem hiding this comment.
I don't know what this is. But I'd like to have cfg_aliase for them.
Contributor
|
Thanks for your PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #14931.