Repository navigation
chcon: report verbose write failures without panicking - #15382
Merged
Merged
Conversation
oech3
reviewed
Oct 15, 2026
| println!( | ||
| if self.options.verbose && self.write_error.is_none() { | ||
| self.write_error = writeln!( | ||
| io::stdout().lock(), |
Contributor
There was a problem hiding this comment.
.lock() is not useful when you write just once.
Collaborator
There was a problem hiding this comment.
In general, we found .lock() can be a pessimization for code size, see #14220 (comment).
limadog9
force-pushed
the
fix/chcon-verbose-write-error
branch
from
October 15, 2026 15:03
213ebe9 to
b06d08e
Compare
Contributor
|
Thanks for your PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Report verbose output failures once while continuing file operations. Add a regression covering the panic and continued operand processing.
Closes #13061.