Repository navigation
uucore: look up the -Z context of a relative name by its absolute name - #15336
Conversation
Merging this PR will regress 1 benchmark
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | factor_five_38_bit_primes |
1.6 s | 2 s | -17.03% |
| ⚡ | Simulation | factor_three_39_bit_primes |
567 ms | 291.9 ms | +94.26% |
| ⚡ | Simulation | factor_thirteen_39_bit_primes |
9.5 s | 9 s | +5.85% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing abendrothj:uucore-fscreate-relative-lookup (203d45c) with main (c76f272)
Footnotes
-
70 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
b933376 to
203d45c
Compare
|
Thanks for your PR |
Closes #15335
FsCreateContextasked the policy for the default context of the name as given. The policy lists absolute names only, so a relative name matched nothing, the miss counted as "no default", and the new object kept the type it inherited from its parent. The name now goes throughabsolute_for_policy_lookup, asset_selinux_security_contextalready does forcp -Z.Checked as root on Fedora 44 (enforcing) against GNU 9.12:
mkdir -Zwith a relative name, with-p, and with an absolute name now gets the same type. Addedtest_selinux_default_context_relative_namefor mkdir and one for mkfifo. They run in cargo'starget/tmp, where the SELinux CI job's policy has a default, and fail without the change there; where there's no default they skip.