Repository navigation
Conversation
|
GNU testsuite comparison: |
Merging this PR will degrade performance by 5.44%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Memory | cp_recursive_deep_tree[(120, 4)] |
532.6 KB | 699.2 KB | -23.82% |
| ❌ |
CPU Simulation | mv_single_file |
146.9 ms | 151.5 ms | -3.04% |
| ⚡ |
CPU Simulation | du_deep_tree[(100, 3)] |
1.9 ms | 1.9 ms | +4.43% |
| ⚡ |
CPU Simulation | sort_long_line[10000] |
1.1 ms | 1 ms | +3.67% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing NdekoCode:chown-cannot-read-directory (3649b1e) with main (ae34722)2
Footnotes
-
70 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
No successful run was found on
main(198c615) during the generation of this report, so ae34722 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
|
Please don't rebase unlike you have a good reason. |
|
The failing Tests (unix) job is the OpenBSD one, and Android fails the same test: both take the walkdir path, which never yields the operand itself under min_depth(1), so its own read error still said "cannot access". last_dir now starts from the operand, and the unused PathBuf import went with it. Linux was already right (checked as non-root in Docker). |
…ot open A directory that could not be opened for reading under -R was reported as "cannot access", where GNU says "cannot read directory". The walkdir path used off Linux also printed its diagnostics with -f, which is meant to hide them. Report a directory that does not open, or that opens but cannot be listed, as "cannot read directory", on both traversal paths, and keep -f quiet on both.
…g, trim the comments and the chgrp test
walkdir never yields the root under min_depth(1), so a read error on the operand itself still came out as "cannot access" on the walkdir path (macOS, the BSDs). Start last_dir from the root, and drop the PathBuf import that the Linux build did not use.
099397b to
3649b1e
Compare
|
@sylvestre could you check again ? |
Under
-R, a directory that could not be opened for reading was reported ascannot access 'd/a': Permission denied, where GNU 9.12 sayscannot read directory 'd/a': Permission denied. The same wording was already used when a directory opened but could not be listed. The walkdir path used off Linux also printed these diagnostics with-f, which hides them in GNU.Both traversal paths now report a directory that does not open, or that opens but cannot be listed, as
cannot read directory, through one shared message, and-fkeeps both quiet. The two Linux tests that pinned the old wording are updated, and a test for each utility covers the message and-f. The chgrp and chown suites pass on Linux and macOS.Closes #15154 (the chmod half is in #15166).