Skip to content

du: show suffixes for unit-only block sizes - #15008

Open
mattsu2020 wants to merge 1 commit into
uutils:mainfrom
mattsu2020:codex/du-block-size-units
Open

mattsu2020 wants to merge 1 commit into
uutils:mainfrom
mattsu2020:codex/du-block-size-units

Conversation

@mattsu2020

@mattsu2020 mattsu2020 commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

du currently omits the unit label for block sizes such as KiB.
Preserve the label when the multiplier is omitted, while keeping explicit sizes such as 1KiB numeric-only, for both command-line options and environment variables.
Add regression tests for the display and option overrides.

Refs #7738.

@xtqqczze

xtqqczze commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator

@codspeed

codspeed Bot commented Oct 1, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 3.21%

❌ 1 regressed benchmark
✅ 7 untouched benchmarks
⏩ 440 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Simulation du_all_wide_tree[(5000, 500)] 36.9 ms 38.1 ms -3.21%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing mattsu2020:codex/du-block-size-units (f2e7c2f) with main (2b85f6f)

Open in CodSpeed

Footnotes

  1. 440 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Congrats! The gnu test tests/id/setgid is no longer failing!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants