Skip to content

GnuTests: use coreutils-from-gnu #15007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oech3 wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −1
Open

GnuTests: use coreutils-from-gnu #15007

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/GnuTests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,9 @@ jobs:
## Install dependencies
sudo apt-get update
## Check that build-gnu.sh works on the non SELinux system by installing libselinux only on lima
sudo apt-get install -y gperf gdb python3-pyinotify valgrind libexpect-perl libacl1-dev libattr1-dev libcap-dev attr quilt
## Use GNU as system coreutils to avoid trouble e.g. <https://github.com/uutils/coreutils/issues/14998>

@xtqqczze xtqqczze Oct 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for clarity and to isolate --allow-remove-essential, could you write this as as separate command, something like:

Suggested change
## Use GNU as system coreutils to avoid trouble e.g. <https://github.com/uutils/coreutils/issues/14998>
# Use GNU coreutils instead of uutils coreutils, matching the system
# environment expected by the tests.
sudo apt-get install -y coreutils-from-gnu coreutils-from-uutils- --allow-remove-essential

@oech3 oech3 Oct 1, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One command has less network access. I would symlink loop from coreutils --list if I separate it.

@oech3 oech3 Oct 1, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I don't think "environment expected by the tests" is right.

sudo apt-get install -y gperf gdb python3-pyinotify valgrind libexpect-perl libacl1-dev libattr1-dev libcap-dev attr quilt \
coreutils-from-gnu coreutils-from-uutils- --allow-remove-essential
- name: Add various locales
shell: bash
run: |
Expand Down
Loading