GnuTests.yml: let root tests run the uutils build - #15005
Open
abendrothj wants to merge 1 commit into
Open
abendrothj wants to merge 1 commit into
abendrothj wants to merge 1 commit into
Conversation
Collaborator
|
cc: @oech3 |
Contributor
|
We just need to install coreutils-from-gnu instead. No?
|
|
GNU testsuite comparison: |
Collaborator
|
1fd81e1 In general, I think we probably should have a CI step that prints the |
Collaborator
@oech3 Alternatively, make sure none of Ubuntu jobs use |
Contributor
|
I guess |
oech3
reviewed
Oct 1, 2026
Comment on lines
+116
to
+121
| - name: "TEMP: show the image's own coreutils" | ||
| shell: bash | ||
| run: | | ||
| dpkg -l rust-coreutils coreutils-from-uutils coreutils | grep '^ii' | ||
| readlink -f /usr/bin/id | ||
| /usr/bin/id --version |
Contributor
There was a problem hiding this comment.
Suggested change
| - name: "TEMP: show the image's own coreutils" | |
| shell: bash | |
| run: | | |
| dpkg -l rust-coreutils coreutils-from-uutils coreutils | grep '^ii' | |
| readlink -f /usr/bin/id | |
| /usr/bin/id --version | |
| - name: "Replace system id with GNU" | |
| shell: bash | |
| run: ln -f $(command -v gnuid) /bin/id |
Contributor
Author
There was a problem hiding this comment.
That makes this test run GNU's id instead of ours. The chroot only falls back to /usr/bin because nobody can't reach our build; once it can, the system id isn't used.
abendrothj
force-pushed
the
gnu-root-tests-use-build
branch
from
October 1, 2026 19:58
1fd81e1 to
85807c8
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root tests switch to
nobodywithchroot --user./home/runneris0750, sonobodycan't reach the build dir and the PATH lookup falls back to the runner's/usr/bincoreutils. On ubuntu-26.04 that's Ubuntu's rust-coreutils, andid/setgidfailed on images still shipping 0.8.0, whoseidexits 1 on an unnamed gid. Allowing traversal on the workspace's parent dirs makes these tests run our build. Checked on the old image:id/setgidpasses, no other root test changes.Closes #14998