refactor: avoid unnecessary HashSet::contains - #14985
Merged
Merged
Conversation
xtqqczze
force-pushed
the
refactor-du-hashset-contains
branch
from
September 30, 2026 16:40
a34ed3f to
6718535
Compare
Merging this PR will degrade performance by 3.58%
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
Collaborator
Author
|
@samueltardieu I'm surprised Clippy doesn't suggest replacing a |
Collaborator
Author
|
Benchmark variance tracked by #14984. |
xtqqczze
marked this pull request as ready for review
September 30, 2026 19:40
Replace the `contains` + `insert` pair used for inode tracking with a single `HashSet::insert` call. This reduces two hash table lookups to one while preserving existing behavior.
xtqqczze
force-pushed
the
refactor-du-hashset-contains
branch
from
September 30, 2026 20:50
6718535 to
cf8fd9a
Compare
HashSet::contains
|
GNU testsuite comparison: |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the
contains+insertpair with a singleHashSet::insertcall.This reduces two hash table lookups to one while preserving existing behavior.