-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
tee: exercise short writes through splice fallback #14979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -239,6 +239,12 @@ grep -rlE '/usr/local/bin/\s?/usr/local/bin' init.cfg tests/* | xargs -r "${SED} | |
| # we should not regress our project just to match what GNU is going. | ||
| # So, do some changes on the fly | ||
|
|
||
| # strace only injects faults into traced calls. Include splice to force tee's | ||
| # stdout path to use read/write and exercise short-write retries. The | ||
| # replacement stops matching after the first edit, avoiding duplicate options. | ||
| sed -i 's/-e trace=write /-e trace=write,splice -e fault=splice /' \ | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does it mean splice fails only for fd=1 if
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That is OK. But I'd like to add test case with failure of splice for fd=0 at different PR. Both uses write_all, but they exist on different place.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I’ll address it in a separate PR. |
||
| tests/tee/short-write.sh | ||
|
|
||
| sed -i -e "s|removed directory 'a/'|removed directory 'a'|g" tests/rm/v-slash.sh | ||
|
|
||
| # 'rel' doesn't exist. Our implementation is giving a better message. | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.