Skip to content

show-utils.sh: remove dependency on dirname - #14955

Closed
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:show-utils-dirname
Closed

oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:show-utils-dirname

Conversation

@oech3

@oech3 oech3 commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@oech3
oech3 marked this pull request as ready for review September 29, 2026 12:38
@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Congrats! The gnu test tests/id/setgid is no longer failing!

@xtqqczze

Copy link
Copy Markdown
Collaborator

dirname is a portable POSIX utility, why avoid it?

@oech3

oech3 commented Sep 29, 2026 via email

Copy link
Copy Markdown
Contributor Author

@xtqqczze

Copy link
Copy Markdown
Collaborator

util/show-utils.sh is a Unix shell script, and dirname is a standard POSIX utility...

@oech3

oech3 commented Sep 29, 2026 via email

Copy link
Copy Markdown
Contributor Author

@xtqqczze

Copy link
Copy Markdown
Collaborator

sed is also POSIX. I don't see why we should complicate a Unix shell script to accommodate non-Unix consumers who don't have a suitable POSIX environment set up.

@oech3 oech3 closed this Sep 29, 2026
@oech3
oech3 deleted the show-utils-dirname branch September 29, 2026 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants