Skip to content

printenv: Honor QUOTING_STYLE environment variable - #14857

Open
RenjiSann wants to merge 1 commit into
uutils:mainfrom
RenjiSann:printenv-quoting-style
Open

RenjiSann wants to merge 1 commit into
uutils:mainfrom
RenjiSann:printenv-quoting-style

Conversation

@RenjiSann

@RenjiSann RenjiSann commented Sep 25, 2026 •

Copy link
Copy Markdown
Collaborator

Depends on #14856

Make printenv check for QUOTING_STYLE and adapt its output accordingly

Should make tests/misc/printenv.sh pass

DIFF

@github-actions

github-actions Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

GNU testsuite comparison:

Congrats! The gnu test tests/env/printenv is no longer failing!

@codspeed

codspeed Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

1 warning, 1 note

⚠️ 122 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

ℹ️ 1 benchmark has no flamegraph

The flamegraph wasn't generated: most of the time was spent in runtime internals, which would leave nothing useful to analyze.

See affected benchmarks

✅ 401 untouched benchmarks
⏩ 70 skipped benchmarks1


Comparing RenjiSann:printenv-quoting-style (f5d5286) with main (1d6ca65)2

Open in CodSpeed

Footnotes

  1. 70 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (e90b788) during the generation of this report, so 1d6ca65 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@RenjiSann
RenjiSann force-pushed the printenv-quoting-style branch 2 times, most recently from 738e4bd to 4e9570c Compare September 25, 2026 11:35
@RenjiSann
RenjiSann force-pushed the printenv-quoting-style branch 3 times, most recently from 7808763 to 1b977c0 Compare September 28, 2026 13:34
@cakebaker

Copy link
Copy Markdown
Contributor

@RenjiSann the dependency has been merged in the meantime :)

@RenjiSann
RenjiSann force-pushed the printenv-quoting-style branch from 1b977c0 to 79d38b1 Compare October 5, 2026 12:09
@RenjiSann

Copy link
Copy Markdown
Collaborator Author

@RenjiSann the dependency has been merged in the meantime :)

Yep, but the GNU test isn't fixed just yet, I'll investigate

@RenjiSann
RenjiSann force-pushed the printenv-quoting-style branch from 79d38b1 to 8ca4cfa Compare October 13, 2026 09:45
@RenjiSann
RenjiSann force-pushed the printenv-quoting-style branch 3 times, most recently from 2ff7ce1 to 78e92ed Compare October 21, 2026 15:58
@RenjiSann
RenjiSann marked this pull request as ready for review October 21, 2026 17:28
@xtqqczze

This comment was marked as outdated.

@RenjiSann
RenjiSann requested a review from cakebaker October 22, 2026 08:31
@RenjiSann
RenjiSann force-pushed the printenv-quoting-style branch from 78e92ed to b48a514 Compare October 23, 2026 16:44
@RenjiSann
RenjiSann requested a review from sylvestre October 25, 2026 23:22
@RenjiSann
RenjiSann force-pushed the printenv-quoting-style branch from b48a514 to 1bd918f Compare October 25, 2026 23:26
@RenjiSann
RenjiSann force-pushed the printenv-quoting-style branch from 1bd918f to f5d5286 Compare October 25, 2026 23:26

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants