Skip to content

install: retry strip program spawn on ETXTBSY - #14646

Open
krosci wants to merge 1 commit into
uutils:mainfrom
krosci:fix/install-strip-text-file-busy
Open

krosci wants to merge 1 commit into
uutils:mainfrom
krosci:fix/install-strip-text-file-busy

Conversation

@krosci

@krosci krosci commented Sep 17, 2026 •

Copy link
Copy Markdown

On Linux, exec(2) of a script (e.g. the #!/bin/sh strip wrapper) transiently fails with ETXTBSY when another process is concurrently exec'ing the same interpreter, because the kernel denies write access to the file for the duration of the exec; CI's parallel test load turns this into an intermittent failure. BSD kernels already sleep and retry on ETXTBSY (see exec(3)), and install now does the same, retrying the strip-program spawn up to three times with a short delay, so genuine errors (missing program, permission, non-zero exit) still fail immediately. Unit tests cover the retry path and confirm only ETXTBSY triggers a retry.

Closes #14520

@github-actions

github-actions Bot commented Sep 17, 2026 •

Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/date/resolution (passes in this run but fails in the 'main' branch)

@krosci
krosci force-pushed the fix/install-strip-text-file-busy branch from 680b59c to db64ed6 Compare September 18, 2026 10:51
@krosci

krosci commented Sep 18, 2026

Copy link
Copy Markdown
Author

@xtqqczze could you take a look at it? Thanks!

@xtqqczze

Copy link
Copy Markdown
Collaborator

could you take a look at it? Thanks!

With #14586, it would be possible to remove all the cfg(unix) annotations. I’ll wait for a decision on that PR before proceeding.

@krosci
krosci force-pushed the fix/install-strip-text-file-busy branch from 04fc3ef to ddb44cc Compare September 20, 2026 10:32
//
// For the full copyright and license information, please view the LICENSE
// file that was distributed with this source code.

@xtqqczze xtqqczze Sep 20, 2026 •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase to remove the unrelated whitespace changes.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's already at the last commit.


runs-on: ubuntu-latest
if: >
github.event.workflow_run.event == 'pull_request' &&

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, this is a bad merge.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to cherry-pick from the commit before @sylvestre pushed a merge commit into your branch:

git fetch upstream
git checkout fix/install-strip-text-file-busy
git reset --hard upstream/main
git cherry-pick db64ed6cbe422cc36f2035625fe7774f27094dbd

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe I'm done

@krosci
krosci force-pushed the fix/install-strip-text-file-busy branch from ddb44cc to bb3412a Compare September 20, 2026 13:56
@codspeed

codspeed Bot commented Sep 20, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 15.86%

❌ 1 regressed benchmark
✅ 75 untouched benchmarks
⏩ 355 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
❌ false_consecutive_calls 294.7 ns 350.2 ns -15.86%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing krosci:fix/install-strip-text-file-busy (ddb44cc) with main (93e535b)2

Open in CodSpeed

Footnotes

  1. 355 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (47df573) during the generation of this report, so 93e535b was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@krosci
krosci force-pushed the fix/install-strip-text-file-busy branch 3 times, most recently from 91bfe9b to 39df9cf Compare September 23, 2026 15:22
@krosci
krosci force-pushed the fix/install-strip-text-file-busy branch from 39df9cf to 3d9711b Compare September 25, 2026 20:47

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test_install_and_strip intermittent failure

2 participants