env: support --env0-from by wtcpython · Pull Request #14609 · uutils/coreutils

wtcpython · 2026-09-16T14:36:06Z

Support --env0-from=FILE to read environment variables from a NUL-delimited file, matching GNU env 9.12.

Should make test tests/env/env0-from.sh pass

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

github-actions · 2026-09-17T02:25:22Z

GNU testsuite comparison:

Congrats! The gnu test tests/env/env0-from is no longer failing!
Congrats! The gnu test tests/id/setgid is no longer failing!

oech3 · 2026-09-17T05:26:53Z

#14626 was submitted at 1st

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

cakebaker · 2026-09-29T08:36:38Z

+        .succeeds()
+        .stdout_move_str();
+
+    assert!(!out.lines().any(|line| line == "UU_ENV0_OPAQUE_14609"));


I think the assert should be without negation. If I manually run the command with GNU env (printf "UU_ENV0_OPAQUE_14609\0" | env --env0-from=-), the string shows up in the list.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Copilot review overview

Review effort: Lite
Findings: 2 · 2

Open (4)

This loop dereferences ptr (*ptr) without first checking whether ptr itself is null. If… · New
Temporarily overwriting the global environ pointer is not thread-safe (it can race with other… · New
entry_key returns Some(&[] ) for entries that start with = (i.e., an empty name). Downstream… · New
On non-Unix, --env0-from clears the environment and then silently skips entries that are opaque… · New

+                    unsafe {
+                        let mut ptr = *environ();
+                        while !(*ptr).is_null() {
+                            let cstr = std::ffi::CStr::from_ptr(*ptr);
+                            writer.write_all(cstr.to_bytes())?;
+                            match opts.line_ending {
+                                LineEnding::Nul => writer.write_all(b"\0")?,
+                                LineEnding::Newline => writer.write_all(b"\n")?,
+                            }
+                            ptr = ptr.add(1);
+                        }
+                    }


+            let orig = envp_ptrs.as_mut().map(|ptrs| unsafe {
+                let p = *environ();
+                *environ() = ptrs.as_mut_ptr();
+                p
+            });


+    entry
+        .iter()
+        .position(|&b| b == b'=')
+        .map(|pos| &entry[..pos])


+                cmd.env_clear();
+                for entry in entries {
+                    if let Some(key) = entry_key(entry) {
+                        let val = &entry[key.len() + 1..];
+                        if let (Ok(k), Ok(v)) = (std::str::from_utf8(key), std::str::from_utf8(val))
+                        {
+                            cmd.env(k, v);
+                        }
+                    }
+                }


wtcpython force-pushed the env-env0-from branch from d9c06ce to 1f30a20 Compare September 17, 2026 01:40

wtcpython marked this pull request as ready for review September 17, 2026 01:40

Copilot AI lite review requested due to automatic review settings September 17, 2026 01:40

Copilot AI reviewed Sep 17, 2026

Copilot AI review requested due to automatic review settings September 17, 2026 13:27

wtcpython force-pushed the env-env0-from branch from 1f30a20 to 02d6bdb Compare September 17, 2026 13:27

Copilot AI reviewed Sep 17, 2026

Copilot AI review requested due to automatic review settings September 19, 2026 18:25

Copilot AI reviewed Sep 19, 2026

Copilot AI review requested due to automatic review settings September 20, 2026 14:33

wtcpython force-pushed the env-env0-from branch from 9251dbe to 95b3b13 Compare September 20, 2026 14:33

Copilot AI reviewed Sep 20, 2026

Copilot AI review requested due to automatic review settings September 21, 2026 00:34

wtcpython force-pushed the env-env0-from branch from 95b3b13 to 6f59050 Compare September 21, 2026 00:34

Copilot AI reviewed Sep 21, 2026

wtcpython force-pushed the env-env0-from branch from 6f59050 to 6632dee Compare September 21, 2026 06:22

Copilot AI review requested due to automatic review settings September 21, 2026 06:22

Copilot AI reviewed Sep 21, 2026

Copilot AI review requested due to automatic review settings September 21, 2026 06:51

wtcpython force-pushed the env-env0-from branch from 6632dee to c05e0c4 Compare September 21, 2026 06:51

Copilot AI reviewed Sep 21, 2026

wtcpython force-pushed the env-env0-from branch from c05e0c4 to d7b7c92 Compare September 21, 2026 07:13

Copilot AI review requested due to automatic review settings September 21, 2026 07:13

Copilot AI reviewed Sep 21, 2026

wtcpython force-pushed the env-env0-from branch from d7b7c92 to 5aa10c7 Compare September 23, 2026 00:27

Copilot AI review requested due to automatic review settings September 23, 2026 00:27

Copilot AI reviewed Sep 23, 2026

wtcpython force-pushed the env-env0-from branch from 5aa10c7 to e9c0b1d Compare September 25, 2026 00:56

Copilot AI review requested due to automatic review settings September 25, 2026 00:56

Copilot AI reviewed Sep 25, 2026

wtcpython force-pushed the env-env0-from branch from e9c0b1d to 8f80bf8 Compare September 27, 2026 00:39

Copilot AI review requested due to automatic review settings September 27, 2026 00:39

Copilot AI reviewed Sep 27, 2026

wtcpython force-pushed the env-env0-from branch from 8f80bf8 to d6ffe2c Compare September 29, 2026 06:09

Copilot AI review requested due to automatic review settings September 29, 2026 06:09

Copilot AI reviewed Sep 29, 2026

cakebaker reviewed Sep 29, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings September 29, 2026 08:55

wtcpython force-pushed the env-env0-from branch from d6ffe2c to b32ed9d Compare September 29, 2026 08:55

Copilot AI reviewed Sep 29, 2026

Copilot AI review requested due to automatic review settings September 29, 2026 09:24

wtcpython force-pushed the env-env0-from branch from b32ed9d to d50b48a Compare September 29, 2026 09:24

Copilot AI reviewed Sep 29, 2026

Copilot AI review requested due to automatic review settings September 29, 2026 11:22

wtcpython force-pushed the env-env0-from branch from d50b48a to 90fce30 Compare September 29, 2026 11:22

Copilot AI reviewed Sep 29, 2026

Copilot AI lite review requested due to automatic review settings September 30, 2026 03:20

wtcpython force-pushed the env-env0-from branch from 90fce30 to 99e2977 Compare September 30, 2026 03:20

Copilot AI reviewed Sep 30, 2026

env: support --env0-from

7b15a3b

Copilot AI lite review requested due to automatic review settings October 1, 2026 11:40

wtcpython force-pushed the env-env0-from branch from 99e2977 to 7b15a3b Compare October 1, 2026 11:40

Copilot AI reviewed Oct 1, 2026

View reviewed changes

Copilot started reviewing on behalf of wtcpython October 1, 2026 12:31 View session

Uh oh!

Conversation

wtcpython commented Sep 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Sep 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oech3 commented Sep 17, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

cakebaker Sep 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

wtcpython commented Sep 16, 2026 •

edited

Loading

github-actions Bot commented Sep 17, 2026 •

edited

Loading