who: implement for Windows by wtcpython · Pull Request #14495 · uutils/coreutils

wtcpython · 2026-09-10T11:21:05Z

who was previously unavailable on Windows.

This adds a backend backed by WTS session information and enables it in the Windows feature set. Option parsing and output formatting remain shared with the Unix implementation.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

codspeed · 2026-09-10T11:51:45Z

Merging this PR will improve performance by 14.68%

⚡ 2 improved benchmarks
✅ 391 untouched benchmarks
⏩ 54 skipped benchmarks¹

Performance Changes

	Mode	Benchmark	`BASE`	`HEAD`	Efficiency
⚡	Simulation	`three_39_bit_primes`	533 ms	459.1 ms	+16.1%
⚡	Simulation	`five_38_bit_primes`	1.8 s	1.6 s	+13.28%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.

_{Comparing wtcpython:who-windows (ff35f60) with main (2b85f6f)}

54 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

github-actions · 2026-09-10T12:04:08Z

GNU testsuite comparison:

Skipping an intermittent issue tests/date/resolution (passes in this run but fails in the 'main' branch)

oech3 · 2026-09-13T05:34:38Z

+        reason = "signature shared across platforms"
+    )]
+    pub(crate) fn exec(&mut self) -> UResult<()> {
+        println!("{}", translate!("who-unsupported-openbsd"));


If it is actually not supported, this code should be removed. We don't suppprt building stubs.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

sylvestre · 2026-09-16T21:24:22Z

sorry, could you please rebase it

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

HackingRepo · 2026-09-30T12:27:46Z

it bloated with 10 unsafes can we reduce it, safe rust can do some of these things?

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

oech3 · 2026-09-30T13:13:49Z

This PR adds platform specific unsafe, but not for all. windows_sys generally requires many unsafes. I don't know any reasonable safe-wrapper for Win32APIs.

Copilot

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Copilot review overview

Review effort: Lite
Findings: 1 · 4

Open (5)

On Windows, only select.sessions is honored; other selection modes (e.g., --boot, --runlevel,… · New
now_local().unwrap() can panic if the local offset/timezone cannot be determined (which may be… · New
WtsBuffer::drop unconditionally calls WTSFreeMemory even if the pointer is null. While some… · New
The pid column is populated with session.id (a WTS session ID), which is not a process ID and… · New
With who now enabled for Windows, the existing who tests appear to be moving toward Unix-only… · New

+        for session in sessions(!self.all) {
+            if self.own_terminal_only && current_session != Some(session.id) {
+                continue;
+            }
+            if self.select.sessions && !session.user.is_empty() {
+                self.emit_session(&session)?;
+            }
+        }


+/// minute, and the localized `old` past a day or before the given boot time.
+pub(crate) fn format_idle<'a>(when: i64, since_boot: i64) -> Cow<'a, str> {
+    thread_local! {
+        static NOW: time::OffsetDateTime = time::OffsetDateTime::now_local().unwrap();


+        // SAFETY: the pointer was returned by WTS and is freed exactly once.
+        unsafe { WTSFreeMemory(self.0.cast()) };


+            line: &session.line,
+            time: &time,
+            idle: &idle,
+            pid: &format!("{}", session.id),


 use uutests::new_ucmd;
+#[cfg(unix)]
 use uutests::unwrap_or_return;
+#[cfg(unix)]
 use uutests::util::{TestScenario, expected_result, gnu_cmd_result};
+#[cfg(unix)]
 use uutests::util_name;
 #[test]
 fn test_invalid_arg() {


Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI lite review requested due to automatic review settings September 10, 2026 11:21

Copilot AI reviewed Sep 10, 2026

oech3 reviewed Sep 13, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings September 14, 2026 06:35

wtcpython force-pushed the who-windows branch from 30b8f55 to 786338f Compare September 14, 2026 06:35

Copilot AI reviewed Sep 14, 2026

wtcpython force-pushed the who-windows branch from 786338f to 02d93f9 Compare September 17, 2026 01:06

Copilot AI review requested due to automatic review settings September 17, 2026 01:06

Copilot AI reviewed Sep 17, 2026

Copilot AI review requested due to automatic review settings September 17, 2026 01:27

wtcpython force-pushed the who-windows branch from 02d93f9 to 786d107 Compare September 17, 2026 01:27

Copilot AI reviewed Sep 17, 2026

Copilot AI review requested due to automatic review settings September 17, 2026 01:27

Copilot AI reviewed Sep 17, 2026

Copilot AI review requested due to automatic review settings September 19, 2026 01:16

wtcpython force-pushed the who-windows branch from e274d29 to 837fb02 Compare September 19, 2026 01:16

Copilot AI reviewed Sep 19, 2026

Copilot AI lite review requested due to automatic review settings September 30, 2026 12:16

wtcpython force-pushed the who-windows branch from 837fb02 to 29bb23f Compare September 30, 2026 12:16

Copilot AI reviewed Sep 30, 2026

Copilot AI lite review requested due to automatic review settings September 30, 2026 12:54

wtcpython force-pushed the who-windows branch from 29bb23f to 6a6e3e5 Compare September 30, 2026 12:54

Copilot AI reviewed Sep 30, 2026

Copilot AI lite review requested due to automatic review settings October 1, 2026 11:40

wtcpython force-pushed the who-windows branch from 6a6e3e5 to ff35f60 Compare October 1, 2026 11:40

Copilot AI reviewed Oct 1, 2026

View reviewed changes

Copilot started reviewing on behalf of wtcpython October 1, 2026 12:33 View session

who: implement for Windows

bd2d525

wtcpython force-pushed the who-windows branch from ff35f60 to bd2d525 Compare October 2, 2026 10:41

Copilot AI lite review requested due to automatic review settings October 2, 2026 10:41

Copilot AI reviewed Oct 2, 2026

		// SAFETY: the pointer was returned by WTS and is freed exactly once.
		unsafe { WTSFreeMemory(self.0.cast()) };

Uh oh!

Conversation

wtcpython commented Sep 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

codspeed Bot commented Sep 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will improve performance by 14.68%

Performance Changes

Footnotes

Uh oh!

github-actions Bot commented Sep 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oech3 Sep 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

sylvestre commented Sep 16, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

HackingRepo commented Sep 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

oech3 commented Sep 30, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

wtcpython commented Sep 10, 2026 •

edited

Loading

codspeed Bot commented Sep 10, 2026 •

edited

Loading

github-actions Bot commented Sep 10, 2026 •

edited

Loading

HackingRepo commented Sep 30, 2026 •

edited

Loading