env: trace environment changes with -v by wtcpython · Pull Request #14263 · uutils/coreutils

wtcpython · 2026-08-30T01:48:32Z

GNU traces each environment change in verbose mode, and -vv is just -v
repeated. We printed nothing for -v and dumped the input args for -vv.

Print the same trace lines as GNU (cleaning environ, setenv, unset,
chdir) and drop the argument dump. Add tests for the traced output and for
-vv matching -v.

github-actions · 2026-08-30T02:09:39Z

Binary size comparison:

Individual binary size comparison VS main (threshold: >=5% AND >=4 KB).

Total size of compared binaries: 152.18 MB (+1004 KB, +0.65%)

Significant per-binary changes:
  comm     1.12 MB ->    2.33 MB  (+1.21 MB, +107.29%)

github-actions · 2026-08-30T02:32:32Z

GNU testsuite comparison:

Congrats! The gnu test tests/id/setgid is no longer failing!

sylvestre · 2026-08-30T14:35:33Z

            ));
        }
+        // GNU traces only the unsets that remove something
+        if opts.debug && env::var_os(name).is_some() {


GNU prints unset: unconditionally, even for a variable that isn't set or an invalid name

sylvestre · 2026-08-30T14:36:06Z

+    assert_eq!(result.stderr_str(), "unset:    ENV_VERBOSE_UNSET_ME\n");
+
+    // unsetting a variable that does not exist is not traced
+    let result = new_ucmd!()


GNU does trace it. Should expect unset: ENV_VERBOSE_NOT_SET

sylvestre · 2026-08-30T14:36:34Z

            );
            continue;
        }
+        if opts.debug {


to_string_lossy() mangles non-UTF-8 args - GNU passes the raw bytes through. Write the OsStr bytes to stderr instead. Same at line 1065.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

wtcpython · 2026-09-07T04:08:30Z

@sylvestre ready

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

codspeed · 2026-09-17T14:03:32Z

Merging this PR will degrade performance by 4.97%

⚠️

Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
❌ 2 regressed benchmarks
✅ 390 untouched benchmarks
⏩ 54 skipped benchmarks¹

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Mode	Benchmark	`BASE`	`HEAD`	Efficiency
❌	Simulation	`three_39_bit_primes`	684.4 ms	779.3 ms	-12.18%
❌	Simulation	`five_38_bit_primes`	1.7 s	1.9 s	-6.42%
⚡	Simulation	`thirteen_39_bit_primes`	9.3 s	8.9 s	+4.42%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

_{Comparing wtcpython:env-verbose-trace (18dea1f) with main (5b2e6e0)}

54 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Copilot review overview

Review effort: Lite
Findings: 2

Open (2)

The verbose unset: trace is emitted before validating name. If name is invalid (empty or… · New
The verbose chdir: trace is printed before set_current_dir is attempted. If set_current_dir… · New

 fn apply_unset_env_vars(opts: &Options<'_>) -> Result<(), Box<dyn UError>> {
    for name in &opts.unsets {
+        if opts.debug {
+            let mut error = stderr().lock();
+            let _ = error.write_all(b"unset:    ");
+            let _ = error.write_all_os(name);
+            let _ = error.write_all(b"\n");
+        }
        let native_name = NativeStr::new(name);
        if name.is_empty()
            || native_name.contains('\0').unwrap()


+        if opts.debug {
+            let mut error = stderr().lock();
+            let _ = writeln!(error, "chdir:    {}", d.quote());
+        }
        match env::set_current_dir(d) {
            Ok(()) => d,


Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

sylvestre reviewed Aug 30, 2026

View reviewed changes

wtcpython force-pushed the env-verbose-trace branch 2 times, most recently from 450d95a to 85d29c9 Compare August 31, 2026 01:45

wtcpython force-pushed the env-verbose-trace branch from 85d29c9 to 5abae63 Compare September 7, 2026 03:13

Copilot AI lite review requested due to automatic review settings September 7, 2026 03:13

Copilot AI reviewed Sep 7, 2026

cakebaker mentioned this pull request Sep 10, 2026

Revert "env: trace the environment changes under -v" #14493

Merged

Copilot AI review requested due to automatic review settings September 14, 2026 06:38

wtcpython force-pushed the env-verbose-trace branch from 5abae63 to a1d927e Compare September 14, 2026 06:38

Copilot AI reviewed Sep 14, 2026

Copilot AI review requested due to automatic review settings September 17, 2026 13:35

wtcpython force-pushed the env-verbose-trace branch from a1d927e to 162d6b9 Compare September 17, 2026 13:35

Copilot AI reviewed Sep 17, 2026

Copilot AI review requested due to automatic review settings September 19, 2026 00:36

wtcpython force-pushed the env-verbose-trace branch from 162d6b9 to 63dbf12 Compare September 19, 2026 00:36

Copilot AI reviewed Sep 19, 2026

Copilot AI review requested due to automatic review settings September 23, 2026 00:25

wtcpython force-pushed the env-verbose-trace branch from 63dbf12 to a830bd5 Compare September 23, 2026 00:25

Copilot AI reviewed Sep 23, 2026

Copilot AI review requested due to automatic review settings September 24, 2026 07:39

wtcpython force-pushed the env-verbose-trace branch from a830bd5 to d032fa3 Compare September 24, 2026 07:39

Copilot AI reviewed Sep 24, 2026

Copilot AI review requested due to automatic review settings September 25, 2026 00:55

wtcpython force-pushed the env-verbose-trace branch from d032fa3 to 2627c89 Compare September 25, 2026 00:55

Copilot AI reviewed Sep 25, 2026

wtcpython force-pushed the env-verbose-trace branch from 2627c89 to b0a440f Compare September 27, 2026 00:39

Copilot AI review requested due to automatic review settings September 27, 2026 00:39

Copilot AI reviewed Sep 27, 2026

Copilot AI review requested due to automatic review settings September 29, 2026 06:09

wtcpython force-pushed the env-verbose-trace branch from b0a440f to 0b3c950 Compare September 29, 2026 06:09

Copilot AI reviewed Sep 29, 2026

wtcpython force-pushed the env-verbose-trace branch from 0b3c950 to eea75bb Compare September 30, 2026 03:20

Copilot AI lite review requested due to automatic review settings September 30, 2026 03:20

Copilot AI reviewed Sep 30, 2026

Copilot AI lite review requested due to automatic review settings October 1, 2026 11:40

wtcpython force-pushed the env-verbose-trace branch from eea75bb to 834c47e Compare October 1, 2026 11:40

Copilot AI reviewed Oct 1, 2026

View reviewed changes

Copilot started reviewing on behalf of wtcpython October 1, 2026 12:29 View session

env: trace environment changes with -v

18dea1f

Copilot AI lite review requested due to automatic review settings October 2, 2026 10:41

wtcpython force-pushed the env-verbose-trace branch from 834c47e to 18dea1f Compare October 2, 2026 10:41

Copilot AI reviewed Oct 2, 2026

Uh oh!

Conversation

wtcpython commented Aug 30, 2026

Uh oh!

github-actions Bot commented Aug 30, 2026

Uh oh!

github-actions Bot commented Aug 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sylvestre Aug 30, 2026

Choose a reason for hiding this comment

Uh oh!

sylvestre Aug 30, 2026

Choose a reason for hiding this comment

Uh oh!

sylvestre Aug 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

wtcpython commented Sep 7, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

codspeed Bot commented Sep 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will degrade performance by 4.97%

Performance Changes

Footnotes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented Aug 30, 2026 •

edited

Loading

codspeed Bot commented Sep 17, 2026 •

edited

Loading