Skip to content

ci: build the published macOS and Windows artifacts with PGO - #14246

Merged
sylvestre merged 5 commits into
uutils:mainfrom
sylvestre:pgo-windows
Aug 30, 2026
Merged

ci: build the published macOS and Windows artifacts with PGO#14246
sylvestre merged 5 commits into
uutils:mainfrom
sylvestre:pgo-windows

Conversation

@sylvestre

@sylvestre sylvestre commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@sylvestre
sylvestre marked this pull request as ready for review August 29, 2026 18:55
Copilot AI lite review requested due to automatic review settings August 29, 2026 18:55
Copilot AI reviewed Aug 29, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

github-actions Bot commented Aug 29, 2026 •
edited
Loading

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/cut/bounded-memory (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)

Copilot AI review requested due to automatic review settings August 29, 2026 21:28
Copilot AI reviewed Aug 29, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

github-actions Bot commented Aug 29, 2026 •
edited
Loading

Copy link
Copy Markdown

Binary size comparison:

Individual binary size comparison VS main (threshold: >=5% AND >=4 KB).

Total size of compared binaries: 152.19 MB (+1012 KB, +0.65%)

Significant per-binary changes:
  comm     1.12 MB ->    2.33 MB  (+1.21 MB, +107.29%)

Copilot AI review requested due to automatic review settings August 29, 2026 22:07
Copilot AI reviewed Aug 29, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

oech3
oech3 reviewed Aug 30, 2026
View reviewed changes
Comment thread .github/workflows/CICD.yml Outdated
oech3
oech3 reviewed Aug 30, 2026
View reviewed changes
Comment thread .github/workflows/CICD.yml Outdated
Copilot AI review requested due to automatic review settings August 30, 2026 08:21
Copilot AI reviewed Aug 30, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI review requested due to automatic review settings August 30, 2026 10:58
Copilot AI reviewed Aug 30, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI review requested due to automatic review settings August 30, 2026 14:44
Copilot AI reviewed Aug 30, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@sylvestre sylvestre mentioned this pull request Aug 30, 2026
Closed
Copilot AI review requested due to automatic review settings August 30, 2026 17:15
Copilot AI reviewed Aug 30, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI review requested due to automatic review settings August 30, 2026 19:26
Copilot AI reviewed Aug 30, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@sylvestre
pgo: write the profile before exiting on Windows
69862ad
@sylvestre
tests: make env and expr pass on Windows arm64
2f91a6e
@sylvestre
ci: do not train a PGO profile on Windows arm64
f892e6c 
The instrumented aarch64-pc-windows-msvc binary writes .profraw files that llvm-profdata rejects with "symbol name is empty" (rust-lang/rust#150123, rust-lang/rust#156675). The job keeps building natively, without PGO.
Copilot AI review requested due to automatic review settings August 30, 2026 20:38
Copilot AI reviewed Aug 30, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@sylvestre
sylvestre enabled auto-merge (rebase) August 30, 2026 20:45
@sylvestre
sylvestre disabled auto-merge August 30, 2026 21:38
@sylvestre
sylvestre merged commit bf65901 into uutils:main Aug 30, 2026
140 of 178 checks passed
@sylvestre
sylvestre deleted the pgo-windows branch August 30, 2026 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
+1 more reviewer
@oech3 oech3 oech3 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sylvestre @oech3