Skip to content

Enable PGO on Mac builds too - #14243

Merged
sylvestre merged 2 commits into
uutils:mainfrom
sylvestre:fix/pgo-shellcheck
Aug 29, 2026
Merged

sylvestre merged 2 commits into
uutils:mainfrom
sylvestre:fix/pgo-shellcheck

Conversation

@sylvestre

@sylvestre sylvestre commented Aug 29, 2026 •

Copy link
Copy Markdown
Contributor

No description provided.

The echo mixing ${[@]+[*]} triggered SC2145 (argument mixes string
and array). Use [*]+[*] for the display-only expansion; the actual
cargo invocation already uses the correct [@]+[@] guard.
Copilot AI lite review requested due to automatic review settings August 29, 2026 16:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@sylvestre sylvestre changed the title fix(pgo): fix SC2145 shellcheck warning in build-pgo.sh Enable PGO on Mac builds too Aug 29, 2026
@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/retry (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/cut/bounded-memory (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/printf/printf-surprise is now passing!

@sylvestre
sylvestre merged commit 7410121 into uutils:main Aug 29, 2026
107 of 108 checks passed
@sylvestre
sylvestre deleted the fix/pgo-shellcheck branch August 29, 2026 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants