Skip to content

gnu tests: limit make jobs to nproc output #13991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kevinburke wants to merge 1 commit into
base: main
Choose a base branch
from
Open

gnu tests: limit make jobs to nproc output #13991

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions util/run-gnu-test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,20 @@ echo "path_UUTILS='${path_UUTILS}'"
echo "path_GNU='${path_GNU}'"

# Use GNU nproc for *BSD
NPROC_BIN=$(command -v "${path_GNU}"/src/nproc||command -v nproc)
# `-j` wants a job count: handing it the path to nproc made make read it as a
# (bogus) goal and run with unlimited parallelism, which starves the CI runner.
NPROC=$("${NPROC_BIN}" 2>/dev/null) || NPROC=1
MAKEFLAGS="${MAKEFLAGS} -j ${NPROC}"
if NPROC_COMMAND=$(command -v "${path_GNU}/src/nproc" || command -v nproc); then

@oech3 oech3 Sep 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to assume missing nproc binary as we use GNU's one.

JOBS=$("${NPROC_COMMAND}")
else
JOBS=2
fi
case "${JOBS}" in

@oech3 oech3 Sep 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Believe existing nproc and remove this if block.

'' | 0* | *[!0-9]*)
echo "Error: invalid make job count: '${JOBS}'" >&2
exit 1
;;
esac
MAKEFLAGS="${MAKEFLAGS:+${MAKEFLAGS} }-j${JOBS}"
export MAKEFLAGS
echo "GNU test make job count: ${JOBS}"
Comment on lines +42 to +44
###

cd "${path_GNU}" && echo "[ pwd:'${PWD}' ]"
Expand Down
Loading