Repository navigation
ci: pin buf remote plugins so codegen stays on connect v1 - #216
Merged
scarmuega merged 1 commit intoOct 14, 2026
Merged
Conversation
buf.build/connectrpc/go was unpinned and now resolves to v2.0.0, which emits connectrpc.com/connect/v2 imports that need Go 1.26. publish-go runs Go 1.25, so every PR check failed at publish-go. Pin connectrpc/go to v1.21.0, the last v1 release (go 1.25.0), and pin the other unpinned remote plugins to the versions CI resolves today: protocolbuffers/go v1.36.12, protocolbuffers/python and pyi v36.2, bufbuild/protoschema-jsonschema v0.6.0, grpc-ecosystem/openapiv2 v2.31.0 and community/pseudomuto-doc v1.5.1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
scarmuega
marked this pull request as ready for review
October 12, 2026 17:25
Member
Author
|
Merge observed. Plan: Trellis will verify the human merge evidence, adopt the domain pin, and retire the plan. No further merge action is needed. |
scarmuega
deleted the
work/work-20e50ee6cd8925f29a3c368716b446d7df6ef27c
branch
October 14, 2026 11:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
buf.build/connectrpc/gowas unpinned inbuf.gen.yaml. It now resolves to v2.0.0, which emitsconnectrpc.com/connect/v2imports. Those need Go ≥ 1.26, butpublish-goruns Go 1.25.x. So every PR's "PR Code Generation Check" has failed at publish-go since 2026-09-23.Change
buf.gen.yamlonly. Every remote plugin now carries an explicit version:go 1.25.0)Apart from connectrpc/go, each pin is the current BSR latest, which is the version CI resolves today.
grpc/python, the local plugins, the dotnet templates and publish-go's Go version are unchanged. Moving to connect v2 is left for a separate decision.Verification
buf generate protoover just the remote plugins resolves every pin. The generated Go importsconnectrpc.com/connect(v1) 12 times andconnect/v2none.🤖 Generated with Claude Code