Skip to content

fix(query): count grouped, distinct and aggregate reads by their rows #1020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abnegate merged 3 commits into from
Oct 15, 2026
Merged

fix(query): count grouped, distinct and aggregate reads by their rows #1020

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e88fd0
fix(query): count grouped, distinct and aggregate reads by their rows
abnegate Oct 15, 2026
4eda93a
fix(sum): range-check a sum of grouped or distinct rows on mariadb an…
abnegate Oct 15, 2026
81d2fc0
test(query): count a distinct join without a select
abnegate Oct 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Database/Adapter/MariaDB.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1174,6 +1174,12 @@ protected function dialectBuilder(): SQLBuilder&Scoping
return new MariaDBBuilder();
}

#[\Override]
protected function rangeChecked(string $expression): string
{
return $expression.' + 0';
}

#[\Override]
protected function boundsJoinedSort(): bool
{
Expand Down
Loading
Loading