Repository navigation
Conversation
Contributor
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryUpdates notes and todos on a copy, then commits only accepted edits.
No actionable issues found. Tests were inspected but not run during this review. Reviews (1) · Last reviewed commit: "fix(tools): preserve records when an upd..." · Reviewed by Greptile |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rejected note and todo updates currently modify fields before validating the rest of the item. For example, changing a note's title alongside empty content returns failure but keeps the new title; an invalid todo status can similarly retain earlier edits. A later successful operation writes those rejected changes to disk.
Validate and mutate a shallow copy, then apply it to the original record only when the whole item is accepted. Successful siblings in todo batches still succeed; rejected records and timestamps stay unchanged.
Closes #1609.
Validation on macOS/Apple Silicon, Python 3.12.14, against upstream
98e3df14:git diff --checkpasses.make check-allstops at the same 940 Pyright errors as unchanged upstream. The 86 diagnostics in the two edited modules also match the baseline after normalizing line numbers.These are local temporary-file tests. No LLM, cloud account or live scan was used. The full suite stalled in the same provider-test area as unchanged upstream and was interrupted: the patch reached 1,884 passed, 19 failed and 3 xfailed; the base reached 1,879 passed, the same 19 failed and 3 xfailed. Existing failures are in budget/runner tests with stale mocks missing
skillsortelemetry. This PR does not claim a completed or green full suite.