Repository navigation
Conversation
Preview approval requiredThis pull request comes from a fork, so Mintlify won't build a preview until someone with write access approves commit |
Contributor
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryStrix now checks
Reviews (1) · Last reviewed commit: "fix(runtime): honor shell-selected Docke..." · Reviewed by Greptile |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
DOCKER_HOSTis unset, a shell-selectedDOCKER_CONTEXTis ignored and Strix connects to the saved current context instead. This can start a scan against a different Docker daemon or report a connection failure despite the selected environment working.Consult
DOCKER_CONTEXTbefore the saved context, preserving explicit-host precedence and existing TLS handling. An explicitdefaultselects the default connection; an unknown context fails instead of silently falling back. Document the selection order.Closes #1610.
Validation on macOS/Apple Silicon, Python 3.12.14, against current upstream
98e3df14:git diff --checkpasses.make check-allstops at 940 Pyright errors, matching the unchanged upstream baseline.Endpoint selection was compared with Docker CLI 29.7.2. No Docker sandbox, live daemon connection, LLM requests or target scans were exercised.