Support 16 KB page sizes, and fix the build - #1
Open
nsingh-ut wants to merge 3 commits into
Open
Conversation
A duplicate <intent-filter> left over from the autoVerify change made the manifest un-parseable, failing processProdDebugMainManifest. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Replaces the literal "GPR_PACKAGE_URL" placeholder, which is not a URL, so com.userzoom:sdk:+ had no repository to resolve from. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
MapLibre 10.3.0 ships libmapbox-gl.so with 4 KB LOAD alignment, which triggers the OS compatibility warning on 16 KB devices. 11.13.5 is 16 KB aligned; it renames the package, hence the import churn. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Makes the demo app 16 KB page-size compatible, so it runs without the OS
"Android App Compatibility" warning on Android 15+ devices, and fixes two
things that stopped the repo building at all.
1. Malformed
AndroidManifest.xml(build blocker)A duplicate
<intent-filter>sat directly above the real<intent-filter android:autoVerify="true">with only one closing tag, so thefile was not well-formed XML and
processProdDebugMainManifestfailed. It camein with the autoVerify change and has been broken on
mainsince.2.
GPR_PACKAGE_URLplaceholder (build blocker)build.gradledeclaredmaven { url "GPR_PACKAGE_URL" }— a literal string,not a URL — so
com.userzoom:sdk:+had no repository to resolve from. Nowpoints at the public repo the SDK is actually published to, which means the
demo always picks up the latest published UZ SDK.
3. 16 KB page-size support
Measured LOAD-segment alignment of every native lib in the APK:
libmapbox-gl.so→libmaplibre.so0x1000❌0x4000✅libimage_processing_util_jni.so0x4000✅0x4000✅libsurface_util_jni.so0x4000✅0x4000✅liblanguage_id_l2c_jni.so0x4000✅0x4000✅MapLibre was the only offender. Bumped
10.3.0→11.13.5(and the annotationplugin
2.0.2→3.0.2). MapLibre 11 renamed its packagecom.mapbox.mapboxsdk→org.maplibre.androidandMapboxMap→MapLibreMap,which is the bulk of the diff — mechanical renames, no logic changes.
Note that 16 KB alignment is not monotonic across MapLibre releases: 11.5.0
is aligned, 11.5.2 and 11.6.0 regress to 4 KB, 11.8.8+ are aligned again. Worth
re-checking on any future bump.
desugar_jdk_libs2.0.4→2.1.5, required by UZ SDK 25.x.Testing
Built and installed on an Android 17 (API 37) 16 KB emulator:
zipalign -c -P 16— passes0x4000viallvm-readelf -lMap tiles did not load in my environment, but that is a local TLS
interception issue (
CertPathValidatorException) that also blocks MavenCentral here — unrelated to this change. Worth a sanity check on a normal
network.
Type of change
🤖 Generated with Claude Code